Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -Zpanic-abort-tests #405

Open
ojeda opened this issue Jun 30, 2021 · 0 comments
Open

Use -Zpanic-abort-tests #405

ojeda opened this issue Jun 30, 2021 · 0 comments
Labels
• kbuild Related to building the kernel, `make`, `Kbuild`, `Kconfig` options...

Comments

@ojeda
Copy link
Member

ojeda commented Jun 30, 2021

From #402 (comment):

You will probably want to run the tests with -Zpanic-abort-tests to ensure that a panicking test doesn't crash the whole test process due to -Cpanic=abort. (-Zpanic-abort-tests spawns each test in a subprocess)
@ojeda ojeda added • kbuild Related to building the kernel, `make`, `Kbuild`, `Kconfig` options... prio: normal labels Jun 30, 2021
@ojeda ojeda mentioned this issue Jun 30, 2021
Merged
ojeda pushed a commit that referenced this issue Dec 13, 2023
@anakryiko
bpf: Fix a verifier bug due to incorrect branch offset comparison wit…
dfce9cb 
…h cpu=v4

Bpf cpu=v4 support is introduced in [1] and Commit 4cd58e9
("bpf: Support new 32bit offset jmp instruction") added support for new
32bit offset jmp instruction. Unfortunately, in function
bpf_adj_delta_to_off(), for new branch insn with 32bit offset, the offset
(plus/minor a small delta) compares to 16-bit offset bound
[S16_MIN, S16_MAX], which caused the following verification failure:
  $ ./test_progs-cpuv4 -t verif_scale_pyperf180
  ...
  insn 10 cannot be patched due to 16-bit range
  ...
  libbpf: failed to load object 'pyperf180.bpf.o'
  scale_test:FAIL:expect_success unexpected error: -12 (errno 12)
  #405     verif_scale_pyperf180:FAIL

Note that due to recent llvm18 development, the patch [2] (already applied
in bpf-next) needs to be applied to bpf tree for testing purpose.

The fix is rather simple. For 32bit offset branch insn, the adjusted
offset compares to [S32_MIN, S32_MAX] and then verification succeeded.

  [1] https://lore.kernel.org/all/[email protected]
  [2] https://lore.kernel.org/bpf/[email protected]

Fixes: 4cd58e9 ("bpf: Support new 32bit offset jmp instruction")
Signed-off-by: Yonghong Song <[email protected]>
Signed-off-by: Andrii Nakryiko <[email protected]>
Link: https://lore.kernel.org/bpf/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
• kbuild Related to building the kernel, `make`, `Kbuild`, `Kconfig` options...
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ojeda