Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in hint.rs #729

Merged
merged 2 commits into from
Nov 19, 2017
Merged

Fix typo in hint.rs #729

merged 2 commits into from
Nov 19, 2017

Conversation

noiob
Copy link
Contributor

@noiob noiob commented Nov 18, 2017

No description provided.

@Cobrand
Copy link
Member

Cobrand commented Nov 19, 2017

I'm surprised no one noticed this before. Does this patch actually fixes the "VIDEO_MINIMIZE_ON_FOCUS_LOSS" behavior? Or does it work anyway?

I'm kinda divided on what to do here, renaming the static str is obviously fine because that's what it should be, but renaming everything else will be a serious breaking change for just one letter (and it still makes sense with the old version), but if it didn't work in the first place, I doubt anyone will notice since nobody but you used this before.

@noiob
Copy link
Contributor Author

noiob commented Nov 19, 2017

No, it didn't work before this patch. Just using sdl2::hint::set("SDL_VIDEO_MINIMIZE_ON_FOCUS_LOSS", "0"); instead did work, though, and I assume that anyone who stumbled over this probably used that as a workaround.

@Cobrand
Copy link
Member

Cobrand commented Nov 19, 2017

Either they used a workaround, or left it as it is and didn't notice that it didn't work. Would you mind adding an entry in the changelog for 0.32?

@noiob
Copy link
Contributor Author

noiob commented Nov 19, 2017

Woops, editing the .md file in Typora changed the indentation on some things, should I change that back?

@Cobrand
Copy link
Member

Cobrand commented Nov 19, 2017

No it's fine, thanks 👍

@Cobrand Cobrand merged commit 4f9ed1a into Rust-SDL2:master Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants