Make hints more idiomatic

[phrohdoh]

Current

sdl2::hint::set("SDL_VIDEO_MINIMIZE_ON_FOCUS_LOSS", "0");

Idea

// if this belongs in sdl2::video, then we'll use that
// or if there is a better place for the enum, great
sdl2::hint::set(sdl2::hint::Hint::MinimizeOnFocusLoss, false);

If this is desired let me know and I'll try to make time for an implementation.

[Cobrand]

Depends if there are other "hints" to be added in later versions of SDL2 or not ... If it's 95% sure we're not getting any more from later versions of SDL2, then sure. I think even knowing that we will probably get some more, having a nice enum which can get a last field being "Other" for non implemented hints that we may miss from later versions of SDL2 still make sense. Like this :

pub enum Hint<'a> {
MinimizeOnFocusLoss,
// other hint variants
Other(&'a str) // unknown hint variants here.
}

Ideally we would want to make a separate function for every hint, since some hints are basically equivalent of booleans but other are more complicated like this one. Meaning that some hints would take a boolean as a parameter while others would take a slice ...

But in the meantime I guess that an enum that lists every hint that we currently have is a nice alternative.

Feel free to open a PR !

[phrohdoh]

I'm all for the individual function approach.

Is there a good channel to reach this project's devs at? (irc, gitter, is here the best?, etc)

[Cobrand]

Here is 100% fine, but I can drop by Mozilla 's IRC if someone wants help or to discuss something in particular. I do prefer that discutions keep being here though, keeps everything in one place. Currently I'm the last active maintainer, AngryLawyer drops by once in every few months but that's it. So if you need anything, you should ask me!

…

On Apr 17, 2017, 19:34, at 19:34, Taryn Hill ***@***.***> wrote: I'm all for the individual function approach. Is there a good channel to reach this project's devs at? (irc, gitter, is here the best?, etc) -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #638 (comment)

[phrohdoh]

#639 was a first step towards this.

I will implement more hints as I need them (there may be long periods of time between PRs).
Hopefully others will do the same.

[HollayHorvath]

Keep in mind that the names are different than the names in the SDL Wiki Hint page by not containing the HINT_ part, so e.g. SDL_HINT_MOUSE_FOCUS_CLICKTHROUGH becomes SDL_MOUSE_FOCUS_CLICKTHROUGH and so on.

[ThibaultLemaire]

Without going all the way to independent functions, the enum would IMO already be a step in the right direction. It would help avoid mistakes like this or #1197