Skip to content

Conversation

nnethercote
Copy link
Collaborator

I did this in two steps. Details in individual commits.

- `BuilderMethods::dynamic_alloca` was removed.
- `AddressSpace::DATA` was renamed `AddressSpace::ZERO`.
- `GlobalAlloc` has a new variant `TypeId` which must be handled in
  `scalar_to_backend`; I just copied what the llvm backend does.
- `TargetDataLayout::pointer_{size,align}` were changed from fields to
  methods.
- `TargetDataLayout::parse_from_llvm_datalayout_string` gained a second
  argument.
- Need to create `dcx` in `back::codegen` instead of passing it in.
- LTO changes from rust-lang/rust PR 143388 and PR 144062:
  - `run_fat_lto`, `optimize_fat`, and `autodiff` were merged into
    `run_and_optimize_fat_lto`, and the parameters were changed.
  - `run_thin_lto` parameters were changed.
  - `codegen` parameters were changed.
  - `LtoModuleCodegen` was removed.
- Some `TypeMembershipCodegenMethods` methods changed arguments from
  `String` to `&[u8]`.
- Need to update `target_feature_base_cc.stderr` for an innocuous
  looking DWARF `.loc` entry change.
@nnethercote nnethercote requested a review from LegNeato October 8, 2025 02:03
Copy link
Contributor

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I appreciate the bullet points saying what changed.

@LegNeato LegNeato merged commit 8055b0a into Rust-GPU:main Oct 10, 2025
12 checks passed
@nnethercote nnethercote deleted the update-toolchain-3 branch October 13, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants