Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nr2.0: Fix issue with external crates #3443

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

powerboat9
Copy link
Collaborator

@powerboat9 powerboat9 commented Feb 18, 2025

When visiting an external crate declaration, handle failed crate name lookups. This can happen when Session::load_extern_crate fails to load a crate during the CfgStrip phase.

gcc/rust/ChangeLog:

	* resolve/rust-toplevel-name-resolver-2.0.cc
	(TopLevel::visit): When visiting an external crate declaration,
	handle failed crate name lookups. This can happen when
	Session::load_extern_crate fails to load a crate during the
	CfgStrip phase.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove entries.

Signed-off-by: Owen Avery <[email protected]>
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty philberty added the bug label Feb 19, 2025
@philberty philberty added this to the Name Resolution 2.0 rework milestone Feb 19, 2025
@philberty philberty added this pull request to the merge queue Feb 19, 2025
Merged via the queue into Rust-GCC:master with commit 9a1162d Feb 19, 2025
12 checks passed
@powerboat9 powerboat9 deleted the fix-proc branch February 19, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants