Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI-finished implementation to hide success notification #94

Merged
merged 1 commit into from
Jun 23, 2022
Merged

UI-finished implementation to hide success notification #94

merged 1 commit into from
Jun 23, 2022

Conversation

Boyuan-Deng
Copy link
Contributor

@Boyuan-Deng Boyuan-Deng commented Jun 11, 2022 •
edited
Loading

This PR:

  • hide success notification from user

Linear Discussion

Test

  • tested using local dev mode

@Boyuan-Deng
Copy link
Contributor Author

Would like a review

@vsreekanti
Copy link
Contributor

@Boyuan-Deng, if you don't get a timely review in the future, please ping on Slack so folks are notified.

@Boyuan-Deng Boyuan-Deng merged commit da90798 into main Jun 23, 2022
@Boyuan-Deng Boyuan-Deng deleted the UI-1200-remove-success-notification branch June 23, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsreekanti vsreekanti vsreekanti approved these changes

@agiron123 agiron123 Awaiting requested review from agiron123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Boyuan-Deng @vsreekanti