Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 1204 add sdk command to get local host apikey #72

Merged
merged 27 commits into from
Jun 10, 2022

Conversation

Fanjia-Yan
Copy link
Contributor

This PR seeks to add SDK command .apikey() so that the user is able to run: api_key = aqueduct.apikey()to get the local api key.

  • The implementation follows src/python/bin/aqueduct.py get_apikey() which enables the user to see the API key when running aqueduct server I think.
  • I wrote one test for this apikey() where it tests whether the established client's API key matches the result from running the SDK command. I put the test under integration_tests/sdk/apikey_test.py

@Fanjia-Yan Fanjia-Yan requested review from vsreekanti, kenxu95 and cw75 June 9, 2022 17:42
Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall! Left a few comments inline.

sdk/aqueduct/aqueduct_client.py Outdated Show resolved Hide resolved
sdk/aqueduct/aqueduct_client.py Outdated Show resolved Hide resolved
sdk/aqueduct/aqueduct_client.py Outdated Show resolved Hide resolved
sdk/aqueduct/aqueduct_client.py Outdated Show resolved Hide resolved
integration_tests/sdk/apikey_test.py Outdated Show resolved Hide resolved
integration_tests/sdk/apikey_test.py Outdated Show resolved Hide resolved
@Fanjia-Yan Fanjia-Yan requested a review from cw75 June 10, 2022 20:38
Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Fanjia-Yan Fanjia-Yan merged commit 91ab655 into main Jun 10, 2022
@kenxu95 kenxu95 deleted the eng-1204-add-sdk-command-to-get-local-host-apikey branch June 11, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants