Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 657 frontend allow users to view what tables #55

Merged
merged 18 commits into from
Jun 13, 2022

Conversation

eunice-chan
Copy link
Contributor

Show the base tables associated with the integration and preview (with the MUI data grid component!).

@eunice-chan eunice-chan requested review from agiron123 and cw75 June 7, 2022 22:43
@cw75
Copy link
Contributor

cw75 commented Jun 10, 2022

@likawind could you take a look at this when you get a chance? Thx.

@likawind
Copy link
Contributor

The code makes sense! Would you mind include a screen shot or recording in the PR description? It's a bit tricky to picture what things looks like

@eunice-chan
Copy link
Contributor Author

@likawind Will do! Working on restructuring the code to work with the latest changes in main. A video of what it had looked like is here: https://github.com/aqueducthq/enterprise/pull/426
Will post another video once I successfully merge with main.

Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It seems that you've already merged to main, in that case I think it's ready to go!

@eunice-chan
Copy link
Contributor Author

Also includes non-base tables because this backend change hasn't been merged yet: #60

Screen.Recording.2022-06-10.at.1.40.16.PM.mov

@eunice-chan eunice-chan merged commit e6bbc9b into main Jun 13, 2022
@eunice-chan eunice-chan deleted the eng-657-frontend-allow-users-to-view-what-tables branch June 16, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants