Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1459] Removes need to provide API key, server address when running locally #272

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

vsreekanti
Copy link
Contributor

Describe your changes and why you are making these changes

When running on the same machine as the Aqueduct server, the user shouldn't need to provide the API key or address of the server explicitly -- we should be able to automatically detect it. This PR makes the api_key and aqueduct_address arguments optional on the API client.

Related issue number (if any)

ENG-1459

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • [N/A] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [N/A] If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • [N/A] All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@vsreekanti vsreekanti requested review from kenxu95 and cw75 July 29, 2022 01:24
@vsreekanti vsreekanti added the run_integration_test Triggers integration tests label Jul 29, 2022
@vsreekanti vsreekanti merged commit 6b0a57c into main Jul 29, 2022
@vsreekanti vsreekanti deleted the eng-1459-use-localhost8080-as-default-on-oss-sdk branch July 29, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants