Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Integration Test Timeout #269

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Jul 28, 2022

Describe your changes and why you are making these changes

Updates integration test timeout to wait 5 minutes instead of 1 for server to start.

Hoping that this will remedy failing test here: https://github.com/aqueducthq/aqueduct/runs/7566139306?check_suite_focus=true
per @kenxu95 's suggestion.

Related issue number (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123 agiron123 requested a review from kenxu95 July 28, 2022 22:28
@agiron123 agiron123 added the run_integration_test Triggers integration tests label Jul 28, 2022
@agiron123 agiron123 merged commit fb30483 into main Jul 29, 2022
@agiron123 agiron123 deleted the update-integration-test-timeout branch July 29, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants