[ENG-1354, 1415] Fixes bottom sidesheet and ReactFlow alignment issues #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsreekanti
added
the
skip_integration_test
agiron123
reviewed
Jul 28, 2022
| useEffect(() => { | ||
| fitView(); | ||
| }, []); | ||
| }, [dagPositionState]); | ||
|
|
||
| useEffect(() => { | ||
| // NOTE(vikram): There's a timeout here because there seems to be a |
There was a problem hiding this comment.
I think this is still necessary. This has to do with a race condition between the CSS transition for the div and when the fitView call is made.
agiron123
reviewed
Jul 28, 2022
| @@ -151,9 +151,8 @@ export const AqueductSidebar: React.FC<Props> = ({ | |||
| // open bottom to top | |||
| bottomAligned: { | |||
| position: 'absolute', | |||
| right: bottomSideSheetOffset, | |||
| left: MenuSidebarOffset, | |||
There was a problem hiding this comment.
Not super urgent, but we'll need to add this to the EnterpriseMenuSidebar as well. we use different components on enterprise and OSS
agiron123
approved these changes
Jul 28, 2022
|
Looks good, remember to also update the version number of @aqueducthq/common here as well. We can say something like Here's how the folks at emotion do it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR fixes two bugs around the layout of the ReactFlow canvas and the bottom sidesheet:
fitViewat the right time. Because we were previously callingfitViewoncomponentDidMount, it didn't actually work on the first load because the nodes and edges were loaded in after the component was mounted. This PR changes thefitVieweffect so that it also is called when the node/edge positions are changed, which causes the view to be fit correctly (after a small lag) on first load.(Ignore the miscolored artifacts; that's because my local backend isn't updated.)
Related issue number (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)