Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Upgrade go chi to v5 #260

Merged
merged 6 commits into from
Jul 27, 2022
Merged

[backend] Upgrade go chi to v5 #260

merged 6 commits into from
Jul 27, 2022

Conversation

likawind
Copy link
Contributor

@likawind likawind commented Jul 27, 2022

Describe your changes and why you are making these changes

This PR upgrades go chi to latest version based on @vsreekanti 's comment: "We're currently using an 18-month old release of go-chi because we aren't using the go-modules-ed version of it. We should upgrade."

We refer to chi's official guide to use /chi/v5 and /chi/v5/middleware, changed all imports and updated go.mod and go.sum using go mod tidy.

Related issue number (if any)

ENG-1222

Checklist before requesting a review

Compiles. As long as in-PR test passed, it should be sufficient.

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@likawind likawind added the run_integration_test Triggers integration tests label Jul 27, 2022
Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad that there doesn't seem to be any API changes required. :)

@likawind likawind merged commit f67228c into main Jul 27, 2022
@likawind likawind deleted the eng-1222-upgrade-go-chi branch July 28, 2022 20:44
@likawind likawind mentioned this pull request Aug 4, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants