Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-1407 Allow UI page sidebars to be passed in as prop. #242

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Jul 22, 2022

Describe your changes and why you are making these changes

Refactors sidebar and layout handling to allow sidebar layout to be passed into page components.

Related issue number (if any)

Resolves: https://linear.app/aqueducthq/issue/ENG-1407/refactor-sidebar-and-layout-handling

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123 agiron123 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Jul 22, 2022
@agiron123 agiron123 requested a review from vsreekanti July 22, 2022 06:54
@agiron123 agiron123 merged commit 8d31fa0 into main Jul 22, 2022
@agiron123 agiron123 deleted the eng-1407-refactor-sidebar-and-layout-handling branch July 22, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants