Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a low-overhead way of authenticating S3 integration #236

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

cw75
Copy link
Contributor

@cw75 cw75 commented Jul 21, 2022

Describe your changes and why you are making these changes

Previously we were doing a list operation to check if the user has access to the bucket, which can be very costly if the bucket has lots of files. This low-overhead approach is borrowed from here and I verified that it works.

Related issue number (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@cw75 cw75 requested review from likawind and saurav-c July 21, 2022 22:43
@cw75 cw75 added the run_integration_test Triggers integration tests label Jul 21, 2022
Copy link
Contributor

@saurav-c saurav-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cw75 cw75 merged commit 73b34fd into main Jul 21, 2022
@cw75 cw75 deleted the fix_s3_integration_authentication branch July 21, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants