Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 1427 fix database integration tests #235

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

saurav-c
Copy link
Contributor

@saurav-c saurav-c commented Jul 21, 2022

Describe your changes and why you are making these changes

This PR fixes our database integration tests. One of the operator test cases was failing because we did not update the ID of the expected operator.

It also splits up the make test-database into a couple rules, so that devs can test against specific database types. More documentation for testing can be found here.

Related issue number (if any)

ENG 1427

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
    I tested this PR by running make test-db-sqlite.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@saurav-c saurav-c added the skip_integration_test Skips required integration test (only documentation/UI changes) label Jul 21, 2022
@saurav-c saurav-c requested review from likawind and cw75 July 21, 2022 22:12
Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saurav-c saurav-c merged commit 90f0d79 into main Jul 21, 2022
@saurav-c saurav-c deleted the eng-1427-fix-database-integration-tests branch July 21, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants