Skip to content

Cleanup unzipped function directories properly on OSX #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented Jul 21, 2022

Describe your changes and why you are making these changes

start_function_executor.sh errors on OSX operating systems because of the "${OP_PATH::-3}" expression.

We remove the need for this expression, and thus allow for cleanup of these expanded functions on Macs.

Related issue number (if any)

ENG-1375

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@kenxu95 kenxu95 requested review from cw75 and likawind July 21, 2022 18:19
@kenxu95 kenxu95 added run_integration_test Triggers integration tests bug Something isn't working labels Jul 21, 2022
@kenxu95 kenxu95 changed the title Cleanup unzipped function directories on OSX Cleanup unzipped function directories properly on OSX Jul 21, 2022
@kenxu95 kenxu95 merged commit a7cf79d into main Jul 21, 2022
@kenxu95 kenxu95 deleted the eng-1375-cleanup-unzipped-function-directories-correct branch July 21, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants