Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where parameters argument to head() was unused. #225

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented Jul 19, 2022

Describe your changes and why you are making these changes

See title.

Related issue number (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@kenxu95 kenxu95 added the bug Something isn't working label Jul 19, 2022
@kenxu95 kenxu95 requested a review from Fanjia-Yan July 19, 2022 21:35
@kenxu95 kenxu95 added the run_integration_test Triggers integration tests label Jul 19, 2022
@kenxu95 kenxu95 merged commit e754858 into main Jul 20, 2022
@kenxu95 kenxu95 deleted the fix_head branch July 20, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants