Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 1345 create api endpoint to get tables associated for workflow_id #216

Merged
merged 18 commits into from
Jul 19, 2022

Conversation

eunice-chan
Copy link
Contributor

Describe your changes and why you are making these changes

Created API endpoint that gets all tables for a workflow_id.
Will be used to display tables associated with workflow to choose from to delete when deleting workflow.

Demo

Tested by querying endpoint with a workflow with duplicate integration-table-update_mode operators. Only unique combos are returned.

{"table_details":[{"name":"aqueduct_demo Loader","integration_id":"95ccb2eb-068c-4a85-853c-3a5dced8f192","service":"SQLite","table_name":"test","update_mode":"replace"},{"name":"aqueduct_demo Loader","integration_id":"95ccb2eb-068c-4a85-853c-3a5dced8f192","service":"SQLite","table_name":"test","update_mode":"append"},{"name":"aqueduct_demo Loader","integration_id":"95ccb2eb-068c-4a85-853c-3a5dced8f192","service":"SQLite","table_name":"new_table","update_mode":"append"}]}

Related issue number (if any)

Eng 1345
Eng 1358 (#214): Testing

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • [N/A] All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eunice-chan eunice-chan merged commit df986f3 into main Jul 19, 2022
@vsreekanti vsreekanti deleted the eng-1345-api-endpoint-to-get-tables-associated branch July 20, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants