Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performs Code Structure/Naming changes for Orchestration Refactor #207

Merged
merged 7 commits into from
Jul 14, 2022

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented Jul 11, 2022

Describe your changes and why you are making these changes

From step 1 of https://www.notion.so/aqueducthq/Building-an-Abstraction-Layer-over-Operators-and-Artifacts-in-our-Go-Code-097d67c45e2f4ffe90185305561d178a, this does this following:

  • Rename the database objects in golang/lib/collections
    • WorkflowDAGDBWorkflowDAG
    • OperatorDBOperator
    • ArtifactDBArtifact
  • Fix the layering within our /lib library between lib/collections and lib/workflow. The former should house database-specific struct definitions, and the latter should contain the higher level logic. That is to say lib/workflow should use lib/collections but not the other way around.

Related issue number (if any)

Checklist before requesting a review

  • [x ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • [x ] I have performed a self-review of my code.
  • [ N/A] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [N/A ] If this is a new feature, I have added unit tests and integration tests.
  • [ x] I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@kenxu95 kenxu95 requested review from cw75 and likawind July 11, 2022 23:33
Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenxu95 kenxu95 added the run_integration_test Triggers integration tests label Jul 14, 2022
@kenxu95 kenxu95 merged commit bb116b3 into main Jul 14, 2022
@kenxu95 kenxu95 deleted the refactor_engine_1 branch July 14, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants