Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-868-Add describe() method to each of the relational integrations. #201

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

Fanjia-Yan
Copy link
Contributor

@Fanjia-Yan Fanjia-Yan commented Jul 8, 2022

Describe your changes and why you are making these changes

This PR seeks to add a describe() functionality for relational integrations. The existing relational integration has a describe() method that prints out the integration information. Thereafter, I add a display of list of table inside the integration. The table name displayed is limited to the number of display from df.head() because if there are large number of tables, this method is not user friendly.
Screen Shot 2022-07-07 at 5 29 30 PM

Update

Screen Shot 2022-07-08 at 12 54 56 PM

Related issue number (if any)

https://linear.app/aqueducthq/issue/ENG-868/add-describe-method-to-each-of-the-relational-integrations

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@Fanjia-Yan Fanjia-Yan requested a review from cw75 July 8, 2022 00:22
Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fanjia-Yan Could you make it clear in the print statement that we are only listing the first 5 table names?

@Fanjia-Yan Fanjia-Yan added the run_integration_test Triggers integration tests label Jul 8, 2022
@Fanjia-Yan Fanjia-Yan merged commit 6fdd1a7 into main Jul 8, 2022
@vsreekanti vsreekanti deleted the eng-868-add-describe-method-to-each-of-the branch July 11, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants