Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates churn example to use correct port for UI #200

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

hsubbaraj-spiral
Copy link
Contributor

Describe your changes and why you are making these changes

Updates the churn example notebook to use port 8080 instead of 3000.

Related issue number (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • [n/a] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [n/a] If this is a new feature, I have added unit tests and integration tests.
  • [n/a] I have run the integration tests locally and they are passing.
  • [n/a] All features on the UI continue to work correctly.
  • [n/a] Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Base automatically changed from update_install_script_sagemaker to main July 8, 2022 03:14
@cw75
Copy link
Contributor

cw75 commented Jul 8, 2022

@hsubbaraj-spiral could you do a rebase with main. Thx!

@hsubbaraj-spiral hsubbaraj-spiral added the skip_integration_test Skips required integration test (only documentation/UI changes) label Jul 8, 2022
@hsubbaraj-spiral hsubbaraj-spiral requested a review from cw75 July 8, 2022 17:43
@hsubbaraj-spiral hsubbaraj-spiral merged commit 395732f into main Jul 8, 2022
@hsubbaraj-spiral hsubbaraj-spiral deleted the update_churn_example branch July 8, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants