Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves usage of ci tests by not relying on github paths #190

Merged
merged 3 commits into from
Jul 6, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
- [ ] I have performed a self-review of my code.
- [ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
- [ ] If this is a new feature, I have added unit tests and integration tests.
- [ ] I have manually run the integration tests and they are passing.
- [ ] I have run the integration tests locally and they are passing.
- [ ] All features on the UI continue to work correctly.
- [ ] I have added the appropriate CI label to the PR.
hsubbaraj-spiral marked this conversation as resolved.
Show resolved Hide resolved
5 changes: 0 additions & 5 deletions .github/workflows/pre-merge-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@ name: Pre-Merge Integration tests
on:
pull_request:
types: [ labeled, opened, synchronize, reopened ]
paths:
- 'src/golang/**'
- 'src/python/**'
- 'integration_tests/**'
- 'sdk/aqueduct/**'

jobs:
trigger-integration-tests:
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/skip-pre-merge-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,8 @@ name: Skip Pre-Merge Integration tests
on:
pull_request:
types: [ labeled, opened, synchronize, reopened ]
paths-ignore:
- 'src/golang/**'
- 'src/python/**'
- 'integration_tests/**'
- 'sdk/aqueduct/**'

jobs:
trigger-integration-tests:
if: contains(github.event.pull_request.labels.*.name, 'skip_integration_test')
uses: aqueducthq/aqueduct/.github/workflows/skipped-integration-tests.yml@main