Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the use of ipynbname package in our SDK #184

Merged
merged 9 commits into from
Jul 6, 2022

Conversation

cw75
Copy link
Contributor

@cw75 cw75 commented Jul 1, 2022

Describe your changes and why you are making these changes

The ipynbname has been causing issues whenever a notebook isn't started in the user's own terminal. This PR removes the use of this package and also clean up some deprecated logic in the packaging function. Please see the comments inline for the defensive check added.

Related issue number (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have manually run the integration tests and they are passing.
  • All features on the UI continue to work correctly.

@cw75 cw75 requested review from kenxu95 and hsubbaraj-spiral July 1, 2022 22:24
Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me! But we definitely need an integration test for when the function is in a python file in a different directory, and it makes a relative import from another directory (this may already exist but would be good to check)

Would we be able to modify one of our example notebooks to include an operator defined in a separate python file (with additional dependencies in separate files too)? We can also just create a simple example test notebook and check it with the run-notebook action.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cw75 cw75 added the run_integration_test Triggers integration tests label Jul 6, 2022
@cw75 cw75 requested a review from kenxu95 July 6, 2022 19:29
@cw75
Copy link
Contributor Author

cw75 commented Jul 6, 2022

@kenxu95 could you take another look? I added a notebook integration test.

Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cw75 cw75 merged commit ffc753e into main Jul 6, 2022
@cw75 cw75 deleted the eng-1301-deprecate-the-use-of-ipnybname-in-the branch July 6, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants