Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add ability to trigger a flow with custom parameters #181

Merged
merged 6 commits into from
Jul 1, 2022

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented Jul 1, 2022

Describe your changes and why you are making these changes

Builds a "parameters" form into the workflow trigger dialog. These text fields have the parameter default value as the placeholder. Any value in entered in here will be packaged up and sent to refresh_workflow to trigger the flow with the new parameters. Text fields left empty are ignored. Text fields that have a non-jsonable string in them will be rejected with an appropriate error message.

Demo Vid:
https://www.loom.com/share/c61881ab0f3448a0890b40bccae42519

Related issue number (if any)

ENG-1295

Checklist before requesting a review

  • [x ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [N/A ] If this is a new feature, I have added unit tests and integration tests.
  • I have manually run the integration tests and they are passing.
  • [ x] All features on the UI continue to work correctly.

@kenxu95 kenxu95 requested review from vsreekanti and agiron123 July 1, 2022 18:35
Copy link
Contributor

@agiron123 agiron123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kenxu95 kenxu95 added the run_integration_test Triggers integration tests label Jul 1, 2022
@kenxu95 kenxu95 force-pushed the eng-1295-add-ability-to-trigger-flow-with-custom branch from 1c02ebf to cc8ec15 Compare July 1, 2022 22:20
@kenxu95 kenxu95 merged commit 0038f51 into main Jul 1, 2022
@kenxu95 kenxu95 deleted the eng-1295-add-ability-to-trigger-flow-with-custom branch July 1, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants