Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the update script to update components separately #171

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

cw75
Copy link
Contributor

@cw75 cw75 commented Jun 29, 2022

Describe your changes and why you are making these changes

This PR allows our update script to update components separately. The benefit is that sometimes we may want to update one component from a branch and another component from another branch.

Currently, I split it to ui, golang binaries, sdk, and python executor. You can see these options via the -h flag. If you don't specify any option, it will update all components, including the UI which takes a long time.

I also updated the option flags to be less verbose: --update-ui -> --ui, and --lint-python -> --python.

Related issue number (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have manually run the integration tests and they are passing.
  • All features on the UI continue to work correctly.

@cw75 cw75 requested review from kenxu95 and saurav-c June 29, 2022 23:56
Copy link
Contributor

@saurav-c saurav-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cw75 cw75 added the run_integration_test Triggers integration tests label Jun 30, 2022
@cw75 cw75 added run_integration_test Triggers integration tests and removed run_integration_test Triggers integration tests labels Jun 30, 2022
@cw75 cw75 merged commit eeedb3d into main Jul 1, 2022
@cw75 cw75 deleted the eng-1283-allow-install-script-to-update-separately branch July 1, 2022 22:45
@cw75 cw75 restored the eng-1283-allow-install-script-to-update-separately branch July 6, 2022 19:10
@cw75 cw75 deleted the eng-1283-allow-install-script-to-update-separately branch July 6, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants