Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3034 Frontend Linter Fixes #1405

Merged
merged 3 commits into from
Jun 5, 2023
Merged

ENG-3034 Frontend Linter Fixes #1405

merged 3 commits into from
Jun 5, 2023

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Jun 3, 2023

Describe your changes and why you are making these changes

This PR fixes an issue where the frontend linters fail to run.

Related issue number (if any)

ENG-3034

Loom demo (if any)

https://www.loom.com/share/a0a7b4ab5eb6456baee05c2a881d5230

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123 agiron123 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Jun 3, 2023
Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since we updated package.json could we verify that a full build works? I'd like to confirm that the artf detail page of a table artf does loads content, as that's where we are using the buffer package.

@agiron123
Copy link
Contributor Author

The buffer related changes are in another PR, #1406.

Before merging, I will verify that a full frontend build works with the manual QA tests.

@agiron123 agiron123 force-pushed the eng-3034-linterfix branch from a2097a8 to 109bb91 Compare June 5, 2023 23:23
@agiron123
Copy link
Contributor Author

@likawind updated demo can be found here:
https://www.loom.com/share/37d0299fce5148bc9fbb59d028d051ce

@agiron123 agiron123 merged commit a3702c8 into main Jun 5, 2023
@agiron123 agiron123 deleted the eng-3034-linterfix branch June 5, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants