Fix resource editing dialog crashing #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-3050-fix-a-bug-where-edit-resource-dialog-crashes
likawind
added
the
skip_integration_test
eunice-chan
force-pushed
the
eng-3050-fix-a-bug-where-edit-resource-dialog-crashes
branch
from
985a510 to
97c770a
Compare
…localpy' into eng-3050-fix-a-bug-where-edit-resource-dialog-crashes
…localpy' into eng-3050-fix-a-bug-where-edit-resource-dialog-crashes
…g-3050-fix-a-bug-where-edit-resource-dialog-crashes
agiron123
reviewed
May 30, 2023
| @@ -1,6 +1,9 @@ | |||
| import React from 'react'; | |||
| import * as Yup from 'yup'; | |||
|
|
|||
| export const AzureDialog: React.FC = () => null; | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
This is placeholder for now, right?
agiron123
approved these changes
May 30, 2023
8 tasks
likawind
commented
May 30, 2023
| @@ -108,23 +115,24 @@ const ResourceDialog: React.FC<Props> = ({ | |||
| // We do this so we can collect name form inputs inside the same form context. | |||
| const name = data.name; | |||
| // remove the name key from data so pydantic doesn't throw error. | |||
| delete data.name; | |||
| const config = { ...data }; | |||
There was a problem hiding this comment.
@eunice-chan I've manually included your change in #1381 here, so feel free to close the PR!
8 tasks
likawind
deleted the
eng-3050-fix-a-bug-where-edit-resource-dialog-crashes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR fixes resource dialog crashing issue in edit mode. We also added edit mode support for all refactored dialogs by properly fetching the values on current resources, and disable requirements on certain fields (e.g. credentials).
Related issue number (if any)
ENG-3050
Loom demo (if any)
Tested on editing S3, WIP testing on more integrations
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)