Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken engine_configs due to integration/resource naming inconsistency #1379

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented May 26, 2023

Describe your changes and why you are making these changes

Related issue number (if any)

ENG-3052

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@kenxu95 kenxu95 requested review from cw75 and eunice-chan May 26, 2023 16:49
Copy link
Contributor

@eunice-chan eunice-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. How have you tested this?

@kenxu95 kenxu95 added the run_integration_test Triggers integration tests label May 26, 2023
@kenxu95 kenxu95 merged commit cf1d495 into main May 26, 2023
@kenxu95 kenxu95 deleted the eng-3052-investigate-backwards-compatible-method-to-consistently-use branch May 26, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants