-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG 3042 Use checks status in workflow status #1376
ENG 3042 Use checks status in workflow status #1376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do notice some edge case where the fix may not work, and have some suggestions on better organizing the code. I'd let you decide if code reorg could come separately as they may be easier when combining with #1374 , but do consider them as immediate follow-ups if you decide not to do them in these two PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just one minor comment!
Describe your changes and why you are making these changes
Use checks status as part of the workflow status.
Related issue number (if any)
ENG 3042
Loom demo (if any)
Succeed with warning
Failed due to check
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)