Skip to content

ENG-3028: Use string to validate port for email dialog and maria db dialog #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2023

Conversation

agiron123
Copy link
Contributor

Describe your changes and why you are making these changes

This PR makes it so strings are used for port field in the email dialog and mariadb dialog.

Related issue number (if any)

ENG-3028

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123 agiron123 added the skip_integration_test Skips required integration test (only documentation/UI changes) label May 24, 2023
@agiron123 agiron123 changed the base branch from main to rc_v034 May 24, 2023 21:33
@agiron123 agiron123 merged commit 8dcf75a into rc_v034 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants