Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation to gate a test case only for relational data integration #1356

Merged
merged 1 commit into from
May 23, 2023

Conversation

jpurusho65
Copy link
Contributor

Describe your changes and why you are making these changes

Annotate a test case to restrict it for relational data integration only

Related issue number (if any)

ENG-3017

Loom demo (if any)

Checklist before requesting a review

  • [x ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • [ x] I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • [ x] I have run the integration tests locally and they are passing.
  • [x ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • [x ] All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@jpurusho65 jpurusho65 requested a review from kenxu95 May 23, 2023 00:25
@jpurusho65 jpurusho65 force-pushed the eng-3017-gate-a-specific-test-case-for-relation branch from 8e629f5 to 31cc93f Compare May 23, 2023 00:27
@jpurusho65 jpurusho65 added the run_integration_test Triggers integration tests label May 23, 2023
@jpurusho65 jpurusho65 merged commit 6387345 into main May 23, 2023
@jpurusho65 jpurusho65 deleted the eng-3017-gate-a-specific-test-case-for-relation branch May 23, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants