-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to parameterize S3 Saves #1354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, since it will soon have customer use case, how hard it is to include an integration test for this?
assert ( | ||
len(spec.parameters.table) == 0 | ||
), "A parameterized relational save spec should have an empty table name." | ||
spec.parameters.table = param_input_vals[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming we are not supporting parametrizing a portion of the table name here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct
@likawind added a data resource test for it. |
Describe your changes and why you are making these changes
This PR allows a user to parameterize the filepath of an S3 save like this (as shown in the demo):
Considerations:
Limitations and bugs:
Related issue number (if any)
ENG-2998
Loom demo (if any)
https://www.loom.com/share/1e616042edd843e9a7845bd619f696c7
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)