Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Github Action for Airflow compute test #1348

Merged
merged 20 commits into from
May 22, 2023

Conversation

saurav-c
Copy link
Contributor

@saurav-c saurav-c commented May 22, 2023

Describe your changes and why you are making these changes

This PR adds a github action for running the Airflow compute tests once a week.

See https://github.com/aqueducthq/aqueduct/actions/runs/5043163833/jobs/9044608060 for an example run. Ignore the failures for now. These will all be filed as linear tasks that are beyond the scope of this task.

Related issue number (if any)

ENG 2599

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reviewers Ignore these changes. This is just a mirror copy of the other file because github actions needs the file to already exist on main in order to test out an action.

with:
prefix: Airflow Compute

# Sets it as an environmental variable.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll uncomment before merging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually will leave this commented out until I finish triaging all of the test case failures. Otherwise there will be a lot of noise generated. See https://linear.app/aqueducthq/issue/ENG-3009/investigate-airflow-integration-test-failures-and-triage-accordingly

@saurav-c saurav-c marked this pull request as ready for review May 22, 2023 07:59
@saurav-c saurav-c added the skip_integration_test Skips required integration test (only documentation/UI changes) label May 22, 2023
@saurav-c saurav-c requested review from kenxu95 and likawind May 22, 2023 07:59
Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good! A few high / low level questions:

  • confirming you are adding back other tests in periodic-integration-tests.yml?
  • should we publish pypi and start the test like how we do it in k8s / spark? What's the cadence of this test? If the same as k8s (and other periodic ones), we could add it as another job in periodic-integration-tests with publish-pypi as a dependency.
  • I see a step copying over DAG template. I'm wondering if we should do this step in install_local.py -e rather than just in testing env?

@saurav-c
Copy link
Contributor Author

@likawind

  1. Yes, this is just for testing.
  2. Sure, we can.
  3. Sure, we can.

@saurav-c saurav-c force-pushed the eng-2851-automate-the-integration-tests-for-airflow branch from ad1c51a to c7c188f Compare May 22, 2023 22:15
@saurav-c saurav-c changed the base branch from eng-2599-fix-airflow-to-aqueduct-syncing to main May 22, 2023 22:15
@saurav-c saurav-c requested a review from likawind May 22, 2023 22:16
@saurav-c
Copy link
Contributor Author

@likawind Addressed everything, see reason why I am leaving slack notif commented out for now.
The Airflow DAG is already copied as part of install_local so no changes needed there.

Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: nice work!

@saurav-c saurav-c merged commit 62f829e into main May 22, 2023
@saurav-c saurav-c deleted the eng-2851-automate-the-integration-tests-for-airflow branch May 22, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants