Fixes Airflow to Aqueduct syncing bug #1347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR fixes a bug with syncing DAG results from Airflow to Aqueduct. The bug was a race condition introduced when multiple requests were trying to fetch the latest DAG results from Airflow and check if these had been previously populated into Aqueduct. The fix is to wrap this logic inside of a DB transaction, such that conflicting writes do not occur.
It also:
LoadOperatorSpec
. There is a task filed to make these changes backwards compatible with existing Airflow clusters going forward.Tests
Related issue number (if any)
ENG 2599
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)