Implement workflow dags endpoint #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunice-chan
requested changes
May 17, 2023
| resp = self.get_response(self.GET_DAGS_TEMPLATE % flow_id) | ||
| resp = resp.json() | ||
|
|
||
| assert len(resp) == 2 |
There was a problem hiding this comment.
To check the format of the response, I cast to a Response class object. I think you can do that for this too. As bonus, it will be easier for me to integrate into the SDK if the Response classes are already written up.
…g-2847-m1-implement-wfiddags-endpoint-with
…g-2847-m1-implement-wfiddags-endpoint-with
agiron123
approved these changes
May 18, 2023
There was a problem hiding this comment.
looks good here, once @eunice-chan's comments are addressed you can go ahead and merge.
likawind
force-pushed
the
eng-2847-m1-implement-wfiddags-endpoint-with
branch
from
76ae52b to
ad3b740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR implements workflow//dags endpoint that allows UI to retrieve workflow's latest dag when no result is avaiable.
Related issue number (if any)
ENG-2847
Loom demo (if any)
backend integration test included, and should be sufficient as no client is calling this endpoint yet.
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)