-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eng 2885 create and test metric and check routes #1323
Conversation
…reate-metric-and-check-routes
…reate-metric-and-check-routes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but could use a little cleanup, particularly in the area of removing comments before it's good to go.
src/golang/cmd/server/handler/v2/node_check_result_content_get.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Appreciate again for adding all tests. I have a couple of naming / organization comments but it should be good to go once these comments are addressed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Appreciate again for adding all tests. I have a couple of naming / organization comments but it should be good to go once these comments are addressed!
Describe your changes and why you are making these changes
Node Metric & Check get and content-get routes.
Same issue with content-get tests as the existing content-get routes so added the content-get tests to the task to investigate the error (ENG-2943)
Related issue number (if any)
ENG-2885
ENG-2943
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)