Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increases timeout for Redshift integration test cluster start and stop #1300

Merged
merged 1 commit into from
May 9, 2023

Conversation

saurav-c
Copy link
Contributor

@saurav-c saurav-c commented May 9, 2023

Describe your changes and why you are making these changes

Sometimes we are seeing transient issues where the Redshift cluster start process times out. This PR bumps the overall start and stop timeout from 20 to 25 min each, and for each state change (i.e. waiting from resuming to ready) the timeout has been modified from 10 to 15 min.

Related issue number (if any)

ENG 2920

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@saurav-c saurav-c added the skip_integration_test Skips required integration test (only documentation/UI changes) label May 9, 2023
@saurav-c saurav-c merged commit 358f9a0 into main May 9, 2023
@saurav-c saurav-c deleted the eng-2920-fix-redshift-integration-test-cluster branch May 9, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants