Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds guardrails for checks on config #1298

Merged

Conversation

hsubbaraj-spiral
Copy link
Contributor

Describe your changes and why you are making these changes

Adds guardrails for checks on config

Related issue number (if any)

https://linear.app/aqueducthq/issue/ENG-2942/fix-global-lazy-setting-for-periodic-test

Loom demo (if any)

Periodic tests run here: https://github.com/aqueducthq/aqueduct/actions/runs/4919283902

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@hsubbaraj-spiral hsubbaraj-spiral added the run_integration_test Triggers integration tests label May 8, 2023
@hsubbaraj-spiral hsubbaraj-spiral requested a review from agiron123 May 8, 2023 22:08
@hsubbaraj-spiral hsubbaraj-spiral merged commit f5db261 into main May 8, 2023
@hsubbaraj-spiral hsubbaraj-spiral deleted the eng-2942-fix-global-lazy-setting-for-periodic branch May 8, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants