Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes doc generation script #1285

Merged
merged 4 commits into from
May 5, 2023
Merged

Fixes doc generation script #1285

merged 4 commits into from
May 5, 2023

Conversation

saurav-c
Copy link
Contributor

@saurav-c saurav-c commented May 4, 2023 •
edited
Loading

Describe your changes and why you are making these changes

Related issue number (if any)

ENG 2907

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@saurav-c saurav-c requested a review from cw75 May 5, 2023 17:24
@saurav-c saurav-c added the skip_integration_test Skips required integration test (only documentation/UI changes) label May 5, 2023
cw75
cw75 approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saurav-c saurav-c merged commit c0ba165 into main May 5, 2023
@saurav-c saurav-c deleted the eng-2907-fix-docs-generation-script-to-reflect branch May 5, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cw75 cw75 cw75 approved these changes

Assignees
No one assigned
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saurav-c @cw75