Fix bug where on-demand k8s integration registration fails on Mac #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _, stdErr, err := lib_utils.RunCmd( | ||
| "cp", | ||
| []string{ | ||
| "-R", |
There was a problem hiding this comment.
should we be using cp -rT here? What was the reason behind the change?
There was a problem hiding this comment.
@hsubbaraj-spiral because Mac's cp doesn't support the -T flag...I can make a comment on this.
|
@hsubbaraj-spiral addressed comment. |
hsubbaraj-spiral
approved these changes
Apr 27, 2023
cw75
added
the
skip_integration_test
agiron123
pushed a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This is due to
env --versiondoes not work on Mac, but sinceenvshould be pre-installed on all common OSes, we can simply skip the check.In addition,
cp -Tis not supported on Mac, so we implement a workaround instead.Tested that the new changes work both on Linux and on Mac.
Related issue number (if any)
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)