-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eng 2735 Add order by and limit parameters for V2 workflow results #1240
Conversation
@@ -184,7 +184,7 @@ func (h *GetWorkflowHandler) Perform(ctx context.Context, interfaceArgs interfac | |||
dags[dbDAG.ID] = constructedDAG | |||
} | |||
|
|||
dagResults, err := h.DAGResultRepo.GetByWorkflow(ctx, args.workflowID, h.Database) | |||
dagResults, err := h.DAGResultRepo.GetByWorkflow(ctx, args.workflowID, "", -1, h.Database) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar here, let's make a comment to these default values, something like:
(
...,
"", // order_by_desc
-1, // limit, -1 means no limit
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! A couple small suggestions but once they are addressed, it should be good to go
I'm not sure if we have a database test for the query you modified, just make sure |
Describe your changes and why you are making these changes
Support
order_by
andlimit
in query params.order_by
assumes it is a column in workflow result dag table.Related issue number (if any)
Eng 2735
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)