Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parcel Build dist prefixing. #124

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Parcel Build dist prefixing. #124

merged 1 commit into from
Jun 21, 2022

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Jun 21, 2022

Adds build:dist option to ui/app/package.json to allow for prefixing of all urls in parceljs builds with /dist.

Removes need for using sed after generating bundles.

Updates make dist command to use npm run build:dist

Should now see the dist prefix showing in our bundles:
image

… in parceljs builds with /dist. Removes need for using sed after generating bundles.
@agiron123 agiron123 requested a review from vsreekanti June 21, 2022 22:10
Copy link
Contributor

@vsreekanti vsreekanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Much better than my previous hack. 🙂

@agiron123 agiron123 merged commit 69862c5 into main Jun 21, 2022
@vsreekanti vsreekanti deleted the parcel-dist-prefixing branch June 23, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants