Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 2635 Add automated periodic testing coverage for MariaDB #1225

Merged
merged 7 commits into from
Apr 19, 2023
Merged

Eng 2635 Add automated periodic testing coverage for MariaDB #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed4eca8
MariaDB
eunice-chan Apr 18, 2023
b58ff30
For testing
eunice-chan Apr 18, 2023
cdb0b40
Switch port
eunice-chan Apr 18, 2023
9930c46
Integration test
eunice-chan Apr 18, 2023
efee055
Lint
eunice-chan Apr 18, 2023
933bc3a
Combine MariaDB & MySQL
eunice-chan Apr 18, 2023
039539d
Lint
eunice-chan Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/periodic-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,22 @@ jobs:
ports:
# Maps tcp port 5432 on service container to the host
- 5432:5432

mariadb:
image: mariadb:10.7
env:
MARIADB_USER: aqueduct
MARIADB_PASSWORD: aqueduct
MARIADB_ROOT_PASSWORD: aqueduct
MARIADB_DATABASE: aqueducttest
options: >-
--health-cmd="mysqladmin ping"
--health-interval 10s
--health-timeout 5s
--health-retries 5
ports:
# Maps tcp port 3306 on service container to 3808 on the host
- 3808:3306
steps:
- uses: actions/checkout@v2

Expand Down
9 changes: 5 additions & 4 deletions integration_tests/sdk/setup_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,12 @@ def setup_data_integrations(client: Client, filter_to: Optional[str] = None) ->
# Stand up the external integration first.
if integration_config["type"] == ServiceType.SQLITE:
_setup_external_sqlite_db(integration_config["database"])

if integration_config["type"] == ServiceType.POSTGRES:
elif integration_config["type"] == ServiceType.POSTGRES:
_setup_postgres_db()

if integration_config["type"] == ServiceType.MYSQL:
elif (
integration_config["type"] == ServiceType.MYSQL
or integration_config["type"] == ServiceType.MARIADB
):
_setup_mysql_db()

client.connect_integration(
Expand Down