Skip to content

Reduce concurrency of k8s tests to 1 #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Reduce concurrency of k8s tests to 1 #1222

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb142ee
changed concurrency of the SDK tests in periodic test to 1
Apr 17, 2023
0b4c52c
increase timeout period
Apr 17, 2023
741461e
adjusted timeout to 180 min
Apr 18, 2023
06b135e
using ubuntu-latest
Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/periodic-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
run-k8s-tests:
runs-on: ubuntu-latest-4-cores
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually try to downgrade this to ubuntu-latest? I don't think we need anything that powerful if we're just doing concurrency 1. We might need to bump the timeout to something slightly more generous for the first run though.

timeout-minutes: 90
timeout-minutes: 180
name: SDK Integration Tests against K8s Compute
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:

- name: Run the SDK Integration Tests
working-directory: integration_tests/sdk
run: pytest aqueduct_tests/ -rP -vv -n 4
run: pytest aqueduct_tests/ -rP -vv -n 1

- name: Teardown K8s Cluster
id: k8s_cleanup # so that we only upload the state on this specific failure.
Expand Down