Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with CUDA versioning on GPUs #1212

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

hsubbaraj-spiral
Copy link
Contributor

Describe your changes and why you are making these changes

Adds cuda_version to the ResourceConfig for the Operator Class.

Related issue number (if any)

Eng-2808

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@hsubbaraj-spiral hsubbaraj-spiral requested a review from cw75 April 14, 2023 18:08
@hsubbaraj-spiral hsubbaraj-spiral added the run_integration_test Triggers integration tests label Apr 14, 2023
@hsubbaraj-spiral hsubbaraj-spiral merged commit a19fd21 into main Apr 17, 2023
@vsreekanti vsreekanti deleted the eng-2808-fix-bug-with-cuda-versioning branch April 18, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants