Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize manual_aq_tests/initialize.py #1180

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented Apr 6, 2023

Describe your changes and why you are making these changes

During the release process I got really tired of having to wait such a long time for all the manual workflows to be deployed. This PR multi-processes it all, but also leaves a --single-threaded option if you don't want the parallelism.

The new stuff takes just 1.5 minutes to complete (including example notebooks).

Related issue number (if any)

ENG-2754

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@kenxu95 kenxu95 requested review from likawind and saurav-c April 6, 2023 19:19
Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenxu95 kenxu95 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 6, 2023
@kenxu95 kenxu95 merged commit cf51920 into main Apr 6, 2023
@kenxu95 kenxu95 deleted the eng-2754-parallelize-manual_qa_testsinitializepy branch April 6, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants