-
Notifications
You must be signed in to change notification settings - Fork 19
Eng 1187 Script to automatically run gitbook snippets #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eng 1187 Script to automatically run gitbook snippets #1172
Conversation
Should we run this as a part of the release process? |
@vsreekanti I think that's a good time to test. I can look into integrating it into the release script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly readability concerns - this is a bit challenging for me to understand and give a good review on.
Can we just run this GH action on every Gitbook commit?
@kenxu95 Happy to chat about how we can integrate this into our testing process. I think running it at release makes sense because it is not as frequent and that way we can be sure the code snippets work with the release version of Aqueduct. However, I think running it on every commit could also be useful to ensure that we are not committing code that does not work and spreads out the work more. Maybe we can do a combination or just have it at one part of the process. |
…nvestigate-an-automated-way-to-keep-all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot better! Thanks for all the work :) Left a bunch of additional style/refactor suggestions, let me know if they don't make sense.
I think would should make a new github action in the gitbook
repo as a follow up? I think it should be triggered on every PR and block the merging. How long does each run take?
@kenxu95 It takes 173.07111406326294 s (about 3 minutes). |
Describe your changes and why you are making these changes
Script to run through Gitbook Python code snippets. Run through all of them except the ones that require lots of set up (integrations) or have workflow UUIDs hard-coded in.
Also fixes bugs discovered via running through the code snippets:
monthly
function instance type check incorrect forday
(DayOfWeek
-->DayOfMonth
).DayOfMonth
exception statement from "Invalid hour value" to "Invalid day value".TODO: Get integrated into our Github Actions. Will work as a follow up task to determine the frequency to run this & get it set up (https://linear.app/aqueducthq/issue/ENG-2748/integrate-into-github-actions).
Related issue number (if any)
Eng 1187
Loom demo (if any)
Script output:
Error Output:
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)