Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds automated periodic testing coverage for Redshift #1168

Merged
merged 8 commits into from
Apr 6, 2023

Conversation

saurav-c
Copy link
Contributor

@saurav-c saurav-c commented Apr 4, 2023

Describe your changes and why you are making these changes

This PR adds periodic data integration testing for Redshift. This currently uses my own AWS credentials since it was significantly more work to try to get a cluster setup with access for everyone. We will come back to this as part of the follow on tasks filed. The other follow on work involves setting up a cron job that just does a spot check of pausing the cluster if it is not being tested against.

Test Run

https://github.com/aqueducthq/aqueduct/actions/runs/4609848565/jobs/8147738620

Related issue number (if any)

ENG 2636

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@saurav-c saurav-c marked this pull request as ready for review April 4, 2023 17:00
@saurav-c saurav-c requested review from kenxu95 and cw75 April 4, 2023 17:17
@saurav-c saurav-c added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 5, 2023
Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is there a task for the cron job on redshift task?

@saurav-c
Copy link
Contributor Author

saurav-c commented Apr 6, 2023

@saurav-c saurav-c merged commit f0d1229 into main Apr 6, 2023
@saurav-c saurav-c deleted the eng-2636-add-automated-periodic-testing-coverage branch April 6, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants