Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where UI builds works in dev mode but not production #1162

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

likawind
Copy link
Contributor

@likawind likawind commented Apr 3, 2023

Describe your changes and why you are making these changes

This PR fixes prod build issue that's related to redux toolkit. The fix follows discussions in reduxjs/redux-toolkit#1960 .

Related issue number (if any)

ENG-2737

Loom demo (if any)

Verified that the prod build (python3 scripts/install_local -u) crashed without the fix, and works with the fix

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@likawind likawind added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 3, 2023
@likawind likawind merged commit 8200dbd into main Apr 3, 2023
@kenxu95 kenxu95 deleted the eng-2737-ui-works-on-development-mode-but-not-in branch April 3, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants