Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation links to Databricks Dialog #1161

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Added documentation links to Databricks Dialog #1161

merged 3 commits into from
Apr 4, 2023

Conversation

hsubbaraj-spiral
Copy link
Contributor

Describe your changes and why you are making these changes

Added documentation links to Databricks Dialog

Related issue number (if any)

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

vsreekanti
vsreekanti approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@vsreekanti vsreekanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second link is missing text, but other than, you're good to go.

src/ui/common/src/components/integrations/dialogs/databricksDialog.tsx Show resolved Hide resolved
@hsubbaraj-spiral hsubbaraj-spiral force-pushed the eng-2371-cleanup-link-to-documentation-from branch from a4ea134 to fef30cd Compare April 3, 2023 23:58
@hsubbaraj-spiral hsubbaraj-spiral added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 4, 2023
@hsubbaraj-spiral hsubbaraj-spiral merged commit f5566d7 into main Apr 4, 2023
@hsubbaraj-spiral hsubbaraj-spiral deleted the eng-2371-cleanup-link-to-documentation-from branch April 4, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsreekanti vsreekanti vsreekanti approved these changes

@agiron123 agiron123 Awaiting requested review from agiron123

Assignees
No one assigned
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsubbaraj-spiral @vsreekanti